asda2432es

✏️ Editing: pr.md

## ✅ PR Feedback Addressed

| Feedback Item | Resolution |
|--------------|------------|
| **Remove compiled files from PR** | Reverted to develop - only source files included in commit |
| **Unused PHP tracking methods** | Verified - tracking is JS-only, no PHP methods to remove |
| **Move Mixpanel tracking** | Moved into `toggleSingleRowVisibility()` function |
| **Only track expand, not collapse** | Now only tracks when showing (expand), not hiding (collapse) |
| **Pass test ID to "See Report"** | Added `row_id: insightsId` to Mixpanel tracking |
| **Move metric logic out of view** | Created `MetricFormatter` class with threshold constants and formatting methods |
| **Remove duplicate blurred class** | Removed duplicate `$rocket_ri_blurred` from `row-right` div |
| **Check duplicate method with PR #8009** | Not a duplicate - `parse_metric_data()` parses JSON from DB, `get_formatted_metrics()` formats for display |

### Files Changed

- **New**: `inc/Engine/Admin/RocketInsights/MetricFormatter.php` - Centralized metric formatting logic
- **Modified**: `inc/Engine/Admin/RocketInsights/Render.php` - Added MetricFormatter dependency injection
- **Modified**: `inc/Engine/Admin/RocketInsights/ServiceProvider.php` - Registered `ri_metric_formatter`
- **Modified**: `src/js/global/ajax.js` - Fixed Mixpanel tracking placement and behavior
- **Modified**: `views/settings/partials/rocket-insights/table-row.php` - Simplified to use pre-formatted metrics

Ubuntu

Sid Gifari From Gifari Industries - BD Cyber Security Team